repo: ngircd
action: commit
revision: 
path_from: 
revision_from: ffad2da835e26a1a457d4f4a16acf6797d4cc71e:
path_to: 
revision_to: 

commit ffad2da835e26a1a457d4f4a16acf6797d4cc71e
Author: Alexander Barton 
Date:   Wed Sep 10 13:03:30 2014 +0200

    Correctly check that a server has a valid hostname and port

    David Binderman  reported the following compiler warning,
    which is a real bug in ngIRCd, thanks!

    conn.c:2077:55: warning: logical not is only applied to the left hand
                             side of comparison [-Wlogical-not-parentheses]

diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c

--- a/src/ngircd/conn.c
+++ b/src/ngircd/conn.c
@@ -1904,7 +1904,7 @@ Check_Servers(void)
 	for (i = 0; i < MAX_SERVERS; i++) {
 		if (Conf_Server[i].conn_id != NONE)
 			continue;	/* Already establishing or connected */
-		if (!Conf_Server[i].host[0] || !Conf_Server[i].port > 0)
+		if (!Conf_Server[i].host[0] || Conf_Server[i].port <= 0)
 			continue;	/* No host and/or port configured */
 		if (Conf_Server[i].flags & CONF_SFLAG_DISABLED)
 			continue;	/* Disabled configuration entry */

-----END OF PAGE-----