repo: ngircd
action: commit
revision: 
path_from: 
revision_from: e160121698e7ec51f3e763dbdb1b76f755e47729:
path_to: 
revision_to: 
git.thebackupbox.net
ngircd
git clone git://git.thebackupbox.net/ngircd
commit e160121698e7ec51f3e763dbdb1b76f755e47729
Author: Alexander Barton 
Date:   Sun Jul 10 14:45:33 2011 +0200

    MorePrivacy: Don't register WHOWAS information

    Citing an email from Florian to the ngIRCd mailing list:

    "I wonder what the expected behaviour is when Conf_MorePrivacy is changed
     from 'yes' to 'no' and the config is reloaded.

     At the moment, WHOWAS will start giving out information on Users that
     were connected during Conf_MorePrivacy=yes period.  If this is not
     wanted, Client_RegisterWhowas() should be changed to not store a record
     when Conf_MorePrivacy is enabled."

    And I think it is "not wanted" :-)

diff --git a/src/ngircd/client.c b/src/ngircd/client.c
index d038fd2481cde6bc01aca29d1669c93fdf01c1ff..
index ..83c80f845a88347678da2fafdb55d8872e9c0418 100644
--- a/src/ngircd/client.c
+++ b/src/ngircd/client.c
@@ -1192,6 +1192,10 @@ Client_RegisterWhowas( CLIENT *Client )

 	assert( Client != NULL );

+	/* Don't register WHOWAS information when "MorePrivacy" is enabled. */
+	if (Conf_MorePrivacy)
+		return;
+
 	now = time(NULL);
 	/* Don't register clients that were connected less than 30 seconds. */
 	if( now - Client->starttime < 30 )

-----END OF PAGE-----