repo: ngircd
action: commit
revision: 
path_from: 
revision_from: d7ad956a06af2bde1cfcf2ed8194b6a84d69d968:
path_to: 
revision_to: 

commit d7ad956a06af2bde1cfcf2ed8194b6a84d69d968
Author: Alexander Barton 
Date:   Wed Oct 27 21:59:51 2010 +0200

    Fix connect attempts to further IP addresses of outgoing server links

    If a hostname resolves to more than one IP address (round-robin DNS,
    IPv4 and IPv6) and an attempt to connect to the first address fails,
    ngIRCd should try to connect to the 2nd address, 3rd address etc.

    But because of a wrong variable used in the call to New_Server(),
    the wrong server structure has been used in further connection attemps
    which possibly lead to connection attempts to already connected servers.

diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c

--- a/src/ngircd/conn.c
+++ b/src/ngircd/conn.c
@@ -207,7 +207,7 @@ cb_connserver(int sock, UNUSED short what)

 		if (ng_ipaddr_af(&Conf_Server[server].dst_addr[0])) {
 			/* more addresses to try... */
-			New_Server(res, &Conf_Server[server].dst_addr[0]);
+			New_Server(server, &Conf_Server[server].dst_addr[0]);
 			/* connection to dst_addr[0] is now in progress, so
 			 * remove this address... */
 			Conf_Server[server].dst_addr[0] =

-----END OF PAGE-----