repo: ngircd
action: commit
revision: 
path_from: 
revision_from: c16133c5ee72256ef5b8fa586e72e5e3598e75bb:
path_to: 
revision_to: 

commit c16133c5ee72256ef5b8fa586e72e5e3598e75bb
Author: Alexander Barton 
Date:   Wed Jan 25 17:11:44 2012 +0100

    New_Connection(): don't set the client hostname twice

    Setting the hostname twice doesn't do much harm a lot, but isn't elegant.
    And for IPv6 addresses, it isn't correct the first time (missing []) ...

diff --git a/src/ngircd/client.c b/src/ngircd/client.c

--- a/src/ngircd/client.c
+++ b/src/ngircd/client.c
@@ -186,7 +186,6 @@ Init_New_Client(CONN_ID Idx, CLIENT *Introducer, CLIENT *TopServer,

 	assert(Idx >= NONE);
 	assert(Introducer != NULL);
-	assert(Hostname != NULL);

 	client = New_Client_Struct();
 	if (!client)
diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c

--- a/src/ngircd/conn.c
+++ b/src/ngircd/conn.c
@@ -1438,7 +1438,7 @@ New_Connection(int Sock)
 		return -1;
 	}

-	c = Client_NewLocal(new_sock, ip_str, CLIENT_UNKNOWN, false);
+	c = Client_NewLocal(new_sock, NULL, CLIENT_UNKNOWN, false);
 	if (!c) {
 		Log(LOG_ALERT,
 		    "Can't accept connection: can't create client structure!");

-----END OF PAGE-----