repo: ngircd
action: commit
revision: 
path_from: 
revision_from: 7faa3ed7d6613f23e998604461f543e763278f7e:
path_to: 
revision_to: 

commit 7faa3ed7d6613f23e998604461f543e763278f7e
Author: Alexander Barton 
Date:   Tue May 22 13:29:31 2012 +0200

    Pidfile_Create(): Don't leak file descriptor on error path

    Detected by cppcheck:
     [src/ngircd/ngircd.c:502]: (error) Resource leak: pidfd

diff --git a/src/ngircd/ngircd.c b/src/ngircd/ngircd.c

--- a/src/ngircd/ngircd.c
+++ b/src/ngircd/ngircd.c
@@ -498,7 +498,8 @@ Pidfile_Create(pid_t pid)

 	len = snprintf(pidbuf, sizeof pidbuf, "%ld\n", (long)pid);
 	if (len < 0 || len >= (int)sizeof pidbuf) {
-		Log( LOG_ERR, "Error converting pid");
+		Log(LOG_ERR, "Error converting pid");
+		close(pidfd);
 		return;
 	}

-----END OF PAGE-----