repo: ngircd
action: commit
revision: 
path_from: 
revision_from: 3e23f7d2c33df287941d26b84c2a26d6ee22faf2:
path_to: 
revision_to: 

commit 3e23f7d2c33df287941d26b84c2a26d6ee22faf2
Author: Alexander Barton 
Date:   Mon Dec 26 17:32:59 2022 +0100

    Channel mode setting: The local server is allowed to work on local channels

    Don't forbid the local server to change modes on local channels: this
    happens when overriding modes on local (&) channels in the server
    configuration file, for example, and is perfectly fine.

    Without this patch, the server worked as expected but showed critical
    error messages for each local channel in its configuration file:

      "Got remote MODE command for local channel!? Ignored."

diff --git a/src/ngircd/irc-mode.c b/src/ngircd/irc-mode.c

--- a/src/ngircd/irc-mode.c
+++ b/src/ngircd/irc-mode.c
@@ -904,7 +904,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
 		if (Client_Type(Client) == CLIENT_SERVER) {
 			/* MODE requests for local channels from other servers
 			 * are definitely invalid! */
-			if (Channel_IsLocal(Channel)) {
+			if (Channel_IsLocal(Channel) && Client != Client_ThisServer()) {
 				Log(LOG_ALERT, "Got remote MODE command for local channel!? Ignored.");
 				return CONNECTED;
 			}

-----END OF PAGE-----