repo: ngircd
action: commit
revision: 
path_from: 
revision_from: 232c7382ded45775f777567183675c3c1f448807:
path_to: 
revision_to: 

commit 232c7382ded45775f777567183675c3c1f448807
Author: Alexander Barton 
Date:   Sun Sep 17 20:16:35 2023 +0200

    Silence compiler warning in Init_New_Client()

    Use strdup() instead of pointless strndup() to fix the following
    compiler warning:

    client.c: In function ‘Init_New_Client’:
    client.c:216:32: warning: ‘strndup’ specified bound 127 exceeds source size 5 [-Wstringop-overread]
      216 |                 client->away = strndup(DEFAULT_AWAY_MSG, CLIENT_AWAY_LEN - 1);
          |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

diff --git a/src/ngircd/client.c b/src/ngircd/client.c

--- a/src/ngircd/client.c
+++ b/src/ngircd/client.c
@@ -213,7 +213,7 @@ Init_New_Client(CONN_ID Idx, CLIENT *Introducer, CLIENT *TopServer,
 		Generate_MyToken(client);

 	if (Client_HasMode(client, 'a'))
-		client->away = strndup(DEFAULT_AWAY_MSG, CLIENT_AWAY_LEN - 1);
+		client->away = strdup(DEFAULT_AWAY_MSG);

 	client->next = (POINTER *)My_Clients;
 	My_Clients = client;

-----END OF PAGE-----