repo: ngircd
action: commit
revision: 
path_from: 
revision_from: 0d503945cb527e275ef6644a234a6876ff61322b:
path_to: 
revision_to: 
git.thebackupbox.net
ngircd
git clone git://git.thebackupbox.net/ngircd
commit 0d503945cb527e275ef6644a234a6876ff61322b
Author: Alexander Barton 
Date:   Sun May 24 23:24:51 2020 +0200

    Revert "Set the "last data" time to "last ping" time when updating the latter"

    This patch completely broke the PING-PONG logic: now ngIRCd never
    disconnects any stale peers but keeps sending out PINGs over and over
    again ...

    The real issue (server disconnects right after connect) will be fixed in
    the next commit, but let's revert to the somewhat "half-broken but
    'known' state" first ...

    This reverts commit 79a917f954bef8089967786bd3597a6e5ff5c336.

diff --git a/src/ngircd/conn-func.c b/src/ngircd/conn-func.c
index 4a2d32d6a70bcb270981da9b671acc99c6630df3..
index ..72d38b8621ff559c9c93903989e7c091b018be79 100644
--- a/src/ngircd/conn-func.c
+++ b/src/ngircd/conn-func.c
@@ -51,7 +51,7 @@ GLOBAL void
 Conn_UpdatePing(CONN_ID Idx)
 {
 	assert(Idx > NONE);
-	My_Connections[Idx].lastping = My_Connections[Idx].lastdata = time(NULL);
+	My_Connections[Idx].lastping = time(NULL);
 }

 /*

-----END OF PAGE-----