repo: ngircd
action: commit
revision: 
path_from: 
revision_from: 05748aa5eeaf75438a0bb238967667605fe4d52e:
path_to: 
revision_to: 

commit 05748aa5eeaf75438a0bb238967667605fe4d52e
Author: Florian Westphal 
Date:   Fri Apr 29 23:15:05 2011 +0200

    parse: fix logical expression testing for non RFC1459 links

    parse.c:284: warning: suggest parentheses around operand of '!' or
    change '&' to '&&' or '!' to '~'

    The expression looks dubious, this should probably be
    an if-not-set, then... test.

diff --git a/src/ngircd/parse.c b/src/ngircd/parse.c

--- a/src/ngircd/parse.c
+++ b/src/ngircd/parse.c
@@ -280,7 +280,7 @@ Validate_Prefix( CONN_ID Idx, REQUEST *Req, bool *Closed )
 	assert( client != NULL );

 	if (!Req->prefix && Client_Type(client) == CLIENT_SERVER
-	    && !Conn_Options(Idx) & CONN_RFC1459
+	    && !(Conn_Options(Idx) & CONN_RFC1459)
 	    && strcasecmp(Req->command, "ERROR") != 0
 	    && strcasecmp(Req->command, "PING") != 0)
 	{

-----END OF PAGE-----