repo: ngircd
action: commit
revision: 
path_from: 
revision_from: 0035e0d77867c961b4db6f121f2b43a8d45688bd:
path_to: 
revision_to: 
git.thebackupbox.net
ngircd
git clone git://git.thebackupbox.net/ngircd
commit 0035e0d77867c961b4db6f121f2b43a8d45688bd
Author: Alexander Barton 
Date:   Tue Jul 18 11:42:07 2023 +0200

    Fix RPL_INVITING message: It must originate from the server

    All numeric replies must originate from an IRC server, never from a
    client. So fix the RPL_INVITING message!

    Thanks tommyrot for reporting this!

    Closes #307.

diff --git a/src/ngircd/irc-op.c b/src/ngircd/irc-op.c
index a309ee9f068fcba162c9f393a8b1d46633c3604c..
index ..2bf9e349b36245dced9ee4485acb43a8b2f1fef7 100644
--- a/src/ngircd/irc-op.c
+++ b/src/ngircd/irc-op.c
@@ -222,9 +222,9 @@ IRC_INVITE(CLIENT *Client, REQUEST *Req)

 	if (Client_Conn(target) > NONE) {
 		/* The target user is local, so we have to send the status code */
-		if (!IRC_WriteStrClientPrefix(from, target, RPL_INVITING_MSG,
-					       Client_ID(from), Req->argv[0],
-					       colon_if_necessary, Req->argv[1]))
+		if (!IRC_WriteStrClient(from, RPL_INVITING_MSG,
+					Client_ID(from), Req->argv[0],
+					colon_if_necessary, Req->argv[1]))
 			return DISCONNECTED;

 		if (Client_HasMode(target, 'a') &&

-----END OF PAGE-----