repo: janusweb
action: commit
revision: 
path_from: 
revision_from: 981313839a14d66f0077bfe41a3c14e16d7eb5ab:
path_to: 
revision_to: 

commit 981313839a14d66f0077bfe41a3c14e16d7eb5ab
Author: James Baicoianu 
Date:   Mon Oct 26 12:13:43 2020 -0700

    Stop  element change event propagation

diff --git a/media/assets/webui/apps/settings/settings.js b/media/assets/webui/apps/settings/settings.js

--- a/media/assets/webui/apps/settings/settings.js
+++ b/media/assets/webui/apps/settings/settings.js
@@ -151,7 +151,8 @@ elation.elements.define('janus.username.picker', class extends elation.elements.
       
     `, this);
     this.elements.usernameform.addEventListener('submit', ev => this.handleFormSubmit(ev));
-    this.elements.clientid.addEventListener('input', ev => this.handleInputChange(ev));
+    this.elements.clientid.addEventListener('input', ev => this.handleInput(ev));
+    this.elements.clientid.addEventListener('change', ev => this.handleInputChange(ev));
     //this.elements.clientid.addEventListener('accept', ev => this.handleFormSubmit(ev));
     elation.events.add(this.elements.clientid, 'accept', ev => this.handleFormSubmit(ev));
     this.elements.clientid.value = player.userid;
@@ -166,10 +167,9 @@ elation.elements.define('janus.username.picker', class extends elation.elements.
     this.elements.submit.disabled = !this.confirm;
     this.setUsername(newname);
   }
-  handleInputChange(ev) {
+  handleInput(ev) {
     let changed = (this.elements.clientid.value != player.userid);
     if (this.confirm) {
-console.log('it changed', changed, this.elements.clientid.value, player.userid);
       this.elements.submit.value = (changed ? this.buttonlabel : this.confirmlabel);
       this.elements.submit.disabled = false;
     } else {
@@ -177,6 +177,9 @@ console.log('it changed', changed, this.elements.clientid.value, player.userid);
       this.elements.submit.disabled = !changed;
     }
   }
+  handleInputChange(ev) {
+    ev.stopPropagation();
+  }
   setUsername(username) {
     this.elements.clientid.value = username;
     if (username != player.userid) {

-----END OF PAGE-----