repo: janusweb
action: commit
revision: 
path_from: 
revision_from: 7c453ffeefbf33162aaf7ead04d33255e6764353:
path_to: 
revision_to: 

commit 7c453ffeefbf33162aaf7ead04d33255e6764353
Author: James Baicoianu 
Date:   Thu Oct 22 23:08:50 2020 -0700

    Don't throw error about invalid key when autocompleting inputs

diff --git a/scripts/room.js b/scripts/room.js

--- a/scripts/room.js
+++ b/scripts/room.js
@@ -1613,10 +1613,16 @@ elation.require([
     }
 */
     this.onKeyDown = function(ev) { 
-      elation.events.fire({type: 'janus_room_keydown', element: this, keyCode: ev.key.toUpperCase(), event: ev});
+      if (ev.key) {
+        // Chrome throws keydown/keyup events with no key attribute when autocomplete fills a form element
+        elation.events.fire({type: 'janus_room_keydown', element: this, keyCode: ev.key.toUpperCase(), event: ev});
+      }
     }
     this.onKeyUp = function(ev) { 
-      elation.events.fire({type: 'janus_room_keyup', element: this, keyCode: ev.key.toUpperCase(), event: ev });
+      if (ev.key) {
+        // Chrome throws keydown/keyup events with no key attribute when autocomplete fills a form element
+        elation.events.fire({type: 'janus_room_keyup', element: this, keyCode: ev.key.toUpperCase(), event: ev });
+      }
     }
     this.onMouseDown = function(ev) { 
       elation.events.fire({type: 'janus_room_mousedown', element: this, event: ev});

-----END OF PAGE-----