repo: janusweb
action: commit
revision: 
path_from: 
revision_from: 2543621d5d4d659ef21b9a308d99cd122fcee5a9:
path_to: 
revision_to: 

commit 2543621d5d4d659ef21b9a308d99cd122fcee5a9
Author: James Baicoianu 
Date:   Sat Mar 13 15:54:58 2021 -0800

    janus-overlay visibility logic

diff --git a/scripts/client.js b/scripts/client.js

--- a/scripts/client.js
+++ b/scripts/client.js
@@ -160,8 +160,6 @@ elation.require(['engine.engine', 'engine.assets', 'engine.things.light_ambient'
       let overlay = this.container.parentNode.querySelector('janus-overlay');
       if (overlay) {
         this.overlay = overlay;
-        elation.events.add(this.player, 'player_enable', ev => { overlay.hide(); });
-        elation.events.add(this.player, 'player_disable', ev => { overlay.show(); });
       }

       elation.engine.assets.initTextureLoaders(this.engine.systems.render, elation.config.get('janusweb.datapath') + 'lib/basis/');
@@ -421,6 +419,19 @@ elation.require(['engine.engine', 'engine.assets', 'engine.things.light_ambient'
       }
     });
     elation.elements.define('janus.overlay', class extends elation.elements.base {
+      init() {
+        super.init();
+        elation.events.add(this.player, 'player_enable', ev => { this.hide(); });
+        elation.events.add(this.player, 'player_disable', ev => { this.show(); });
+      }
+      show() {
+        super.show();
+        elation.events.fire({type: 'overlay_show', element: this});
+      }
+      hide() {
+        super.hide();
+        elation.events.fire({type: 'overlay_hide', element: this});
+      }
     });
   }
 });

-----END OF PAGE-----